10.25.2 by JoviDeCroock · Pull Request #4605 · preactjs/preact

JoviDeCroock · 2024-12-12T07:59:29Z

Notable

Revert unkeyed no-search (#4604, thanks @JoviDeCroock)

We noticed that there's a few unpleasant scenario's that could form from this change, we wanted to be on the safe side here and revert this for the time being. if you run into issues with swapping components placement wise in a list use the key property.

Fixes

Add missing space in hydration mismatch message (Add missing space in hydration mismatch message #4602, thanks @sirreal)

Types

fix max and min type definition to allow number (fix max and min type definition to allow number #4598, thanks @devlux)

Performance

Use == where possible and precompute .length (Use == where possible and precompute .length #4599, thanks @JoviDeCroock)
Check preallocate new children array perf (Check preallocate new children array perf #4595, thanks @JoviDeCroock)

Maintenance

Replace npm-run-all and lint-staged (Replace npm-run-all and lint-staged #4600, thanks @JoviDeCroock)
Remove benches folder (Remove benches folder #4592, thanks @JoviDeCroock)
Dependency maintenance (Dependency maintenance #4594, thanks @JoviDeCroock)

github-actions · 2024-12-12T07:59:56Z

📊 Tachometer Benchmark Results

Summary

duration

create10k: unsure 🔍 -1% - +0% (-5.14ms - +3.16ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -2% - +1% (-0.30ms - +0.17ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -1% - +1% (-1.01ms - +0.83ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -4% - +0% (-0.64ms - +0.06ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -1% - +1% (-0.77ms - +0.61ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 -5% - +3% (-0.09ms - +0.07ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -0% - +1% (-0.09ms - +0.18ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -4% - +2% (-1.38ms - +0.62ms)
^{preact-local vs preact-main}

usedJSHeapSize

create10k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
^{preact-local vs preact-main}
filter-list: unsure 🔍 -0% - +1% (-0.01ms - +0.02ms)
^{preact-local vs preact-main}
hydrate1k: unsure 🔍 -3% - +5% (-0.31ms - +0.46ms)
^{preact-local vs preact-main}
many-updates: unsure 🔍 -0% - +1% (-0.02ms - +0.02ms)
^{preact-local vs preact-main}
replace1k: unsure 🔍 -0% - +1% (-0.00ms - +0.03ms)
^{preact-local vs preact-main}
text-update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
^{preact-local vs preact-main}
todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
^{preact-local vs preact-main}
update10th1k: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
^{preact-local vs preact-main}

Results

create10k

Browser: chrome-headless
Sample size: 50
Built by: CI #4194
Commit: f8650ab

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	937.03ms - 943.58ms	-	unsure 🔍 -1% - +0% -5.14ms - +3.16ms
preact-main	938.74ms - 943.85ms	unsure 🔍 -0% - +1% -3.16ms - +5.14ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.20ms - 19.21ms	-	unsure 🔍 -0% - +0% -0.01ms - +0.00ms
preact-main	19.20ms - 19.22ms	unsure 🔍 -0% - +0% -0.00ms - +0.01ms	-

filter-list

Browser: chrome-headless
Sample size: 50
Built by: CI #4194
Commit: f8650ab

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.44ms - 16.75ms	-	unsure 🔍 -2% - +1% -0.30ms - +0.17ms
preact-main	16.49ms - 16.84ms	unsure 🔍 -1% - +2% -0.17ms - +0.30ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.52ms - 1.55ms	-	unsure 🔍 -0% - +1% -0.01ms - +0.02ms
preact-main	1.52ms - 1.53ms	unsure 🔍 -1% - +0% -0.02ms - +0.01ms	-

hydrate1k

Browser: chrome-headless
Sample size: 50
Built by: CI #4194
Commit: f8650ab

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	66.98ms - 68.22ms	-	unsure 🔍 -1% - +1% -1.01ms - +0.83ms
preact-main	67.00ms - 68.37ms	unsure 🔍 -1% - +1% -0.83ms - +1.01ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	9.92ms - 10.49ms	-	unsure 🔍 -3% - +5% -0.31ms - +0.46ms
preact-main	9.87ms - 10.39ms	unsure 🔍 -4% - +3% -0.46ms - +0.31ms	-

many-updates

Browser: chrome-headless
Sample size: 50
Built by: CI #4194
Commit: f8650ab

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	17.70ms - 18.07ms	-	unsure 🔍 -4% - +0% -0.64ms - +0.06ms
preact-main	17.88ms - 18.47ms	unsure 🔍 -0% - +4% -0.06ms - +0.64ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.76ms - 3.79ms	-	unsure 🔍 -0% - +1% -0.02ms - +0.02ms
preact-main	3.76ms - 3.79ms	unsure 🔍 -1% - +0% -0.02ms - +0.02ms	-

replace1k

Browser: chrome-headless
Sample size: 90
Built by: CI #4194
Commit: f8650ab

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	69.09ms - 70.05ms	-	unsure 🔍 -1% - +1% -0.77ms - +0.61ms
preact-main	69.15ms - 70.14ms	unsure 🔍 -1% - +1% -0.61ms - +0.77ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.96ms - 2.99ms	-	unsure 🔍 -0% - +1% -0.00ms - +0.03ms
preact-main	2.96ms - 2.97ms	unsure 🔍 -1% - +0% -0.03ms - +0.00ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	30.40ms - 30.97ms	-	unsure 🔍 -2% - +1% -0.53ms - +0.30ms
preact-main	30.50ms - 31.10ms	unsure 🔍 -1% - +2% -0.30ms - +0.53ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	35.31ms - 36.63ms	-	unsure 🔍 -3% - +2% -1.07ms - +0.84ms
preact-main	35.39ms - 36.78ms	unsure 🔍 -2% - +3% -0.84ms - +1.07ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	26.58ms - 26.96ms	-	unsure 🔍 -2% - +1% -0.42ms - +0.20ms
preact-main	26.63ms - 27.12ms	unsure 🔍 -1% - +2% -0.20ms - +0.42ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	27.01ms - 28.47ms	-	unsure 🔍 -5% - +2% -1.44ms - +0.58ms
preact-main	27.46ms - 28.87ms	unsure 🔍 -2% - +5% -0.58ms - +1.44ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.25ms - 26.68ms	-	unsure 🔍 -5% - +3% -1.31ms - +0.70ms
preact-main	25.56ms - 26.98ms	unsure 🔍 -3% - +5% -0.70ms - +1.31ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	22.62ms - 23.12ms	-	unsure 🔍 -2% - +1% -0.37ms - +0.34ms
preact-main	22.64ms - 23.13ms	unsure 🔍 -1% - +2% -0.34ms - +0.37ms	-

text-update

Browser: chrome-headless
Sample size: 110
Built by: CI #4194
Commit: f8650ab

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.96ms - 2.08ms	-	unsure 🔍 -5% - +3% -0.09ms - +0.07ms
preact-main	1.97ms - 2.08ms	unsure 🔍 -3% - +5% -0.07ms - +0.09ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.11ms - 1.11ms	-	unsure 🔍 +0% - +0% +0.00ms - +0.00ms
preact-main	1.11ms - 1.11ms	unsure 🔍 -0% - -0% -0.00ms - -0.00ms	-

todo

Browser: chrome-headless
Sample size: 50
Built by: CI #4194
Commit: f8650ab

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.10ms - 34.31ms	-	unsure 🔍 -0% - +1% -0.09ms - +0.18ms
preact-main	34.07ms - 34.25ms	unsure 🔍 -1% - +0% -0.18ms - +0.09ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.22ms - 1.23ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.22ms - 1.22ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

update10th1k

Browser: chrome-headless
Sample size: 50
Built by: CI #4194
Commit: f8650ab

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.01ms - 34.35ms	-	unsure 🔍 -4% - +2% -1.38ms - +0.62ms
preact-main	33.32ms - 34.80ms	unsure 🔍 -2% - +4% -0.62ms - +1.38ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	2.91ms - 2.93ms	-	unsure 🔍 -1% - +0% -0.02ms - +0.01ms
preact-main	2.91ms - 2.93ms	unsure 🔍 -0% - +1% -0.01ms - +0.02ms	-

_{tachometer-reporter-action v2 for CI}

github-actions · 2024-12-12T08:00:42Z

Size Change: 0 B

Total Size: 62.3 kB

ℹ️ View Unchanged

Filename	Size
`compat/dist/compat.js`	4.13 kB
`compat/dist/compat.module.js`	4.06 kB
`compat/dist/compat.umd.js`	4.2 kB
`debug/dist/debug.js`	3.82 kB
`debug/dist/debug.module.js`	3.83 kB
`debug/dist/debug.umd.js`	3.9 kB
`devtools/dist/devtools.js`	260 B
`devtools/dist/devtools.module.js`	274 B
`devtools/dist/devtools.umd.js`	346 B
`dist/preact.js`	4.7 kB
`dist/preact.min.js`	4.72 kB
`dist/preact.min.module.js`	4.72 kB
`dist/preact.min.umd.js`	4.74 kB
`dist/preact.module.js`	4.72 kB
`dist/preact.umd.js`	4.76 kB
`hooks/dist/hooks.js`	1.52 kB
`hooks/dist/hooks.module.js`	1.56 kB
`hooks/dist/hooks.umd.js`	1.6 kB
`jsx-runtime/dist/jsxRuntime.js`	973 B
`jsx-runtime/dist/jsxRuntime.module.js`	947 B
`jsx-runtime/dist/jsxRuntime.umd.js`	1.05 kB
`test-utils/dist/testUtils.js`	451 B
`test-utils/dist/testUtils.module.js`	456 B
`test-utils/dist/testUtils.umd.js`	536 B

_{compressed-size-action}

coveralls · 2024-12-12T08:02:04Z

coverage: 99.615%. remained the same
when pulling f8650ab on 10.25.2
into fcb8d7c on main.

10.25.2

f8650ab

rschristian approved these changes Dec 12, 2024

View reviewed changes

JoviDeCroock merged commit 2beb9f7 into main Dec 12, 2024
14 checks passed

JoviDeCroock deleted the 10.25.2 branch December 12, 2024 08:07

Uh oh!

Conversation

JoviDeCroock commented Dec 12, 2024

Notable

Revert unkeyed no-search (#4604, thanks @JoviDeCroock)

Fixes

Types

Performance

Maintenance

Uh oh!

github-actions bot commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

duration

usedJSHeapSize

Results

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

run-warmup-0

run-warmup-1

run-warmup-2

run-warmup-3

run-warmup-4

run-final

duration

usedJSHeapSize

duration

usedJSHeapSize

duration

usedJSHeapSize

Uh oh!

github-actions bot commented Dec 12, 2024

Uh oh!

coveralls commented Dec 12, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 12, 2024 •

edited

Loading